Renegade Public Forums
C&C: Renegade --> Dying since 2003™, resurrected in 2024!
Home » Tiberian Technologies / Blackhand Studios » Tiberian Technologies Forum » BRenBot GSA broadcasting issue
BRenBot GSA broadcasting issue [message #470839] Fri, 06 July 2012 11:55 Go to next message
iRANian is currently offline  iRANian
Messages: 4299
Registered: April 2011
Karma: 0
General (4 Stars)
BRenBot adds a few erroneous backslashes to the data it sends to GSA, this doesn't matter except that it breaks the passworded option for GSA clients so players can't join a passworded server via GSA if the server is broadcast via the BRenBot module.

index.php?t=getfile&id=14302&private=0


Long time and well respected Renegade community member, programmer, modder and tester.

Scripts 4.0 private beta tester since May 2011.

My Renegade server plugins releases
Re: BRenBot GSA broadcasting issue [message #470844 is a reply to message #470839] Fri, 06 July 2012 12:27 Go to previous messageGo to next message
Gen_Blacky is currently offline  Gen_Blacky
Messages: 3250
Registered: September 2006
Karma: 1
General (3 Stars)
sub generate_rules
{
	my $string;

#	$string .= "\\BW\\1000000";
	$string .= "\\CSVR\\1";
	$string .= "\\DED\\1";
	$string .= "\\DG\\" . $config{'driver_gunner'};;
	$string .= "\\password\\" . serverStatus::getIsPassworded();
	$string .= "\\TC\\" . $config{'team_changing'};
	$string .= "\\FF\\" . $config{'friendly_fire'};
	$string .= "\\SC\\" . $config{'credits'};
	$string .= "\\SSC\\brenbot" . main::BR_VERSION;
	$string .= ( length($brconfig::config_gamespy_broadcast_website) > 0 ) ? "\\Website\\" . $brconfig::config_gamespy_broadcast_website : '';
	$string .= ( length($brconfig::config_gamespy_broadcast_irc) > 0 ) ? "\\IRC\\" . $brconfig::config_gamespy_broadcast_irc : '';
	$string .= ( length($brconfig::config_gamespy_broadcast_teamspeak) > 0 ) ? "\\Teamspeak\\" . $brconfig::config_gamespy_broadcast_teamspeak : '';
	$string .= ( length($brconfig::config_gamespy_broadcast_ventrilo) > 0 ) ? "\\Ventrilo\\" . $brconfig::config_gamespy_broadcast_ventrilo : '';
	$string .= "\\timeleft\\" . serverStatus::getTime();
	return $string;
}


doesn't it need the slashes.


http://s18.postimage.org/jc6qbn4k9/bricks3.png

[Updated on: Fri, 06 July 2012 12:28]

Report message to a moderator

Re: BRenBot GSA broadcasting issue [message #470845 is a reply to message #470839] Fri, 06 July 2012 12:29 Go to previous messageGo to next message
iRANian is currently offline  iRANian
Messages: 4299
Registered: April 2011
Karma: 0
General (4 Stars)
Seems it's not sending whether DG is "0" or "1" at all.

Long time and well respected Renegade community member, programmer, modder and tester.

Scripts 4.0 private beta tester since May 2011.

My Renegade server plugins releases
Re: BRenBot GSA broadcasting issue [message #470846 is a reply to message #470839] Fri, 06 July 2012 13:04 Go to previous messageGo to next message
danpaul88 is currently offline  danpaul88
Messages: 5795
Registered: June 2004
Location: England
Karma: 0
General (5 Stars)
OK, it turns out there are two different problems here.

Whatever third party GSA client you are using is bugged and isn't parsing responses properly when keys have a blank value. If you used a real GSA client it would all work fine, except some of the 'rules' would be shown with no value (as sent by BRenBot).



As for why the values are blank, it looks like BRenBot doesn't even read some of those values from the configuration files anymore... they were probably missed out at some point when the config code was overhauled and nobody has ever noticed because they haven't been using buggy GSA clients.. or nobody actually looks at the server rules...



So, I will fix the second issue for the next version of BRenBot but there's nothing I can do about your buggy client Smile


http://steamsignature.com/card/1/76561197975867233.png
Re: BRenBot GSA broadcasting issue [message #470848 is a reply to message #470839] Fri, 06 July 2012 13:19 Go to previous message
iRANian is currently offline  iRANian
Messages: 4299
Registered: April 2011
Karma: 0
General (4 Stars)
Thanks a bunch!

Long time and well respected Renegade community member, programmer, modder and tester.

Scripts 4.0 private beta tester since May 2011.

My Renegade server plugins releases
Previous Topic: TT w/ BRenBot bug
Next Topic: BRenBot CMSG paging isn't working
Goto Forum:
  


Current Time: Tue Apr 23 22:38:52 MST 2024

Total time taken to generate the page: 0.00748 seconds